Uploaded image for project: 'ejabberd development'
  1. ejabberd development
  2. EJAB-1162

To not include SubID in items publication and deletion messages with non-multiple Pubsub subscriptions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: ejabberd 2.1.1
    • Fix Version/s: None
    • Component/s: Publish-Subscribe
    • Labels:

      Description

      SubID is "mandatory" for multiple subscriptions only :

      XEP-0060 - 7.1.2.4 Inclusion of Subscription ID

      "If a single entity is subscribed to a node multiple times, the service SHOULD notate the event notification so that the entity can determine which subscription identifier(s) generated this event".

      In the case of unique subscription, the SubID is implicit.

      So Ejabberd shouldn't send SubID for publication and deletion messages when the user is subscribe only once to the node. This way, those messages can be sent using multicast (which requires to have an identical stanza for all the recipients).

        Issue Links

          Activity

          kgemayel Karim Gemayel (Inactive) created issue -
          kgemayel Karim Gemayel (Inactive) made changes -
          Field Original Value New Value
          Link This issue relates to EJAB-265 [ EJAB-265 ]
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Priority Blocker [ 1 ] Major [ 3 ]
          Hide
          cromain@process-one.net Christophe Romain (Inactive) added a comment -

          this is needed for pubsub using XEP-0033

          Show
          cromain@process-one.net Christophe Romain (Inactive) added a comment - this is needed for pubsub using XEP-0033
          Hide
          kgemayel Karim Gemayel (Inactive) added a comment -

          This bug has been fixed.

          SubID is not included anymore when there's only one subscription, it is implicit.

          Show
          kgemayel Karim Gemayel (Inactive) added a comment - This bug has been fixed. SubID is not included anymore when there's only one subscription, it is implicit.
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Fix Version/s master [ 11243 ]
          Fix Version/s ejabberd 3.0.0 [ 10280 ]
          mremond@process-one.net Mickaël Rémond made changes -
          Workflow development v3 [ 70914 ] Development v4 [ 81335 ]
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Fix Version/s master [ 11243 ]
          cromain@process-one.net Christophe Romain (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development