Details

      Description

      According to the XEP-0163 ( http://xmpp.org/extensions/xep-0163.html#support ) server is supposed to include this identity in our bare JID if PEP is supported:
          <identity category='pubsub' type='pep'/>
      but what I receive from my server (jabber.belnet.be) is
          <identity category='pubsub' type='service'/>

      I think this server is running ejabberd 2.1.3 but I'm not 100% sure of the exact version. I'll try to check with an admin if possible.

      This bug is really annoying to us because telepathy-gabble used to rely on the server features to check if PEP was supported. This was wrong but ejabberd used to advertise this identity in the server features so we didn't notice this bug until now.
      We are going to fix telepathy-gabble ( https://bugs.freedesktop.org/show_bug.cgi?id=28230 ) but that still won't work as ejabberd doesn't advertise the right identity.

      1. EJAB_1238_21x.patch
        7 kB
        Karim Gemayel
      2. EJAB_1238_30.patch
        8 kB
        Karim Gemayel

        Activity

        Hide
        Christophe Romain
        added a comment -

        I assume your mod_pubsub plugins configuration includes "pep". If not, please includes it.
        we'll double check this part

        Show
        Christophe Romain
        added a comment - I assume your mod_pubsub plugins configuration includes "pep". If not, please includes it. we'll double check this part
        Hide
        Karim Gemayel (Inactive)
        added a comment -

        With ejabberd 2.1.3 and 2.1.x, responses to disco#info requests advertise PEP :

        <iq type="get" to="joe@localhost" id="aac0a" >
        <query xmlns="http://jabber.org/protocol/disco#info"/>
        </iq>
        
        <iq from="joe@localhost" type="result" to="joe@localhost/Psi" id="aac0a" >
        <query xmlns="http://jabber.org/protocol/disco#info">
        <identity category="pubsub" type="pep" />
        <feature var="http://jabber.org/protocol/disco#info" />
        <feature var="vcard-temp" />
        <feature var="msgoffline" />
        <feature var="http://jabber.org/protocol/commands" />
        </query>
        </iq>
        

        I've registered at jabber.belnet.net and apparently PEP is deactivated on this server.

        Show
        Karim Gemayel (Inactive)
        added a comment - With ejabberd 2.1.3 and 2.1.x, responses to disco#info requests advertise PEP : <iq type= "get" to= "joe@localhost" id= "aac0a" > <query xmlns= "http://jabber.org/protocol/disco#info" /> </iq> <iq from= "joe@localhost" type= "result" to= "joe@localhost/Psi" id= "aac0a" > <query xmlns= "http://jabber.org/protocol/disco#info" > <identity category= "pubsub" type= "pep" /> <feature var= "http://jabber.org/protocol/disco#info" /> <feature var= "vcard-temp" /> <feature var= "msgoffline" /> <feature var= "http://jabber.org/protocol/commands" /> </query> </iq> I've registered at jabber.belnet.net and apparently PEP is deactivated on this server.
        Hide
        Guillaume Desmottes
        added a comment -

        Thanks, I'll check with the admin. Which option has to be enabled in the config file?

        Also, is that normal that <identity category='pubsub' type='service'/> is advertised while it's not in your example?

        Show
        Guillaume Desmottes
        added a comment - Thanks, I'll check with the admin. Which option has to be enabled in the config file? Also, is that normal that <identity category='pubsub' type='service'/> is advertised while it's not in your example?
        Hide
        Guillaume Desmottes
        added a comment -

        Note that publishing works: the server returns an IQ result and my contact receive notifications so I doubt that PEP has been disabled.

        Show
        Guillaume Desmottes
        added a comment - Note that publishing works: the server returns an IQ result and my contact receive notifications so I doubt that PEP has been disabled.
        Hide
        David Durvaux
        added a comment -

        Two informations:
        1 / The server is indeed running 2.1.3
        2 / We have disabled PEP as advised by ProcessOne support.

        PEP has been disabled due to the high level of crashes we are experiencing. We will enabled it back as soon as we have a higher level of stability (several crash per days....)

        Show
        David Durvaux
        added a comment - Two informations: 1 / The server is indeed running 2.1.3 2 / We have disabled PEP as advised by ProcessOne support. PEP has been disabled due to the high level of crashes we are experiencing. We will enabled it back as soon as we have a higher level of stability (several crash per days....)
        Hide
        Guillaume Desmottes
        added a comment -

        Thansk for the info David.

        So I guess the bug here is that even is PEP is disabled, publishing events still success. An IQ error should be returned instead.

        Show
        Guillaume Desmottes
        added a comment - Thansk for the info David. So I guess the bug here is that even is PEP is disabled, publishing events still success. An IQ error should be returned instead.
        Hide
        Christophe Romain
        added a comment -

        Karim, i think this /may/ have been fixed. what's the status on this ?

        Show
        Christophe Romain
        added a comment - Karim, i think this /may/ have been fixed. what's the status on this ?
        Hide
        Karim Gemayel (Inactive)
        added a comment -

        Attached are patches for 2.1.x and 3.0.0.

        • Fixed wrongly advertised PEP ;
        • Fixed non-allowed PEP publication;
        • Removed "ejabberd_local" <iq/> handlers and "disco_local_* " hooks with Pubsub namespaces (only "ejabberd_sm" <iq/> handlers and "disco_sm_*" hooks remain) ;
        • Removed mod_pubsub:iq_local/3 as it was used with an ejabberd_local <iq/> handler.
        Show
        Karim Gemayel (Inactive)
        added a comment - Attached are patches for 2.1.x and 3.0.0. Fixed wrongly advertised PEP ; Fixed non-allowed PEP publication; Removed "ejabberd_local" <iq/> handlers and "disco_local_* " hooks with Pubsub namespaces (only "ejabberd_sm" <iq/> handlers and "disco_sm_*" hooks remain) ; Removed mod_pubsub:iq_local/3 as it was used with an ejabberd_local <iq/> handler.
        Hide
        Christophe Romain
        added a comment -

        fixed on 2.1.5
        will be injected shortly on 3.0.0

        Show
        Christophe Romain
        added a comment - fixed on 2.1.5 will be injected shortly on 3.0.0

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              3 years, 37 weeks, 2 days ago

              Issue deployment