Uploaded image for project: 'ejabberd development'
  1. ejabberd development
  2. EJAB-1244

PubSub: only use binary() instead of string() in Host and ServerHost

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Publish-Subscribe
    • Labels:
      None

      Description

      Host and ServerHost are still string()
      this make lots of string replication, cost memory and efficiency.
      the problem is in do_route:
      Host = exmpp_jid:prep_domain_as_list(To)

      we should remove that, write a database migration script, and make sure there are no string() left.

        Activity

        Hide
        cromain@process-one.net Christophe Romain added a comment -

        attached 1st pass including

        • code change
        • database migration

        this needs tests anyway as i'm not sure this does not break the disco features
        this also change ServerHost passed as parameter to pubsub_publish_item hook

        Show
        cromain@process-one.net Christophe Romain added a comment - attached 1st pass including code change database migration this needs tests anyway as i'm not sure this does not break the disco features this also change ServerHost passed as parameter to pubsub_publish_item hook
        Hide
        cromain@process-one.net Christophe Romain added a comment -

        we need to fix that by monday, or change fix version to ejabberd-3.0.0-beta1

        Show
        cromain@process-one.net Christophe Romain added a comment - we need to fix that by monday, or change fix version to ejabberd-3.0.0-beta1

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development