Uploaded image for project: 'ejabberd development'
  1. ejabberd development
  2. EJAB-1576

mod_shared_roster_ldap post merge fixes to upstream

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Cancelled
    • Affects Version/s: ejabberd 2.1.11, ejabberd 2.1.12
    • Fix Version/s: None
    • Labels:
      None

      Description

      The pull request is at https://github.com/processone/ejabberd/pull/32
      Filing a bug so it does not get forgotten.

      Most changes in this branch are fixes to documentation that should have been applied at the moment mod_shared_roster_ldap was incorporated into the upstream project.

      There are also some minor code refactorings: simplifications and cleanups.

      Please review and comment and/or pull.

        Activity

        Hide
        porridge Marcin Owsiany added a comment -

        Ping?

        Show
        porridge Marcin Owsiany added a comment - Ping?
        Hide
        porridge Marcin Owsiany added a comment -

        Ping again?

        Show
        porridge Marcin Owsiany added a comment - Ping again?
        Hide
        porridge Marcin Owsiany added a comment -

        Ping yet again.
        Please let me know if there's something wrong with the patch, I'm happy to improve on it.

        Show
        porridge Marcin Owsiany added a comment - Ping yet again. Please let me know if there's something wrong with the patch, I'm happy to improve on it.
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        we'll look at your patch

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - we'll look at your patch
        Hide
        porridge Marcin Owsiany added a comment -

        I'm really disappointed that this issue is still unresolved after more than 5 months.
        It seems that I have provided a straightforward fix. If there is something wrong with it, please raise your concerns.

        Show
        porridge Marcin Owsiany added a comment - I'm really disappointed that this issue is still unresolved after more than 5 months. It seems that I have provided a straightforward fix. If there is something wrong with it, please raise your concerns.
        Hide
        neustradamus Neustradamus added a comment -

        Any news? It will be nice to have this patch in 2.1.12 and master.

        Show
        neustradamus Neustradamus added a comment - Any news? It will be nice to have this patch in 2.1.12 and master.
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        I'm afraid we never had time to review and inject that patch back in 2012. I'm sorry about your bad experience.
        We'd need to review and adapt to master, Badlop will check this as of github issue #32.

        Now, the EJAB project is obsolete for more than a year so i'm closing this ticket. Let's follow up on https://github.com/processone/ejabberd/pull/32

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - I'm afraid we never had time to review and inject that patch back in 2012. I'm sorry about your bad experience. We'd need to review and adapt to master, Badlop will check this as of github issue #32. Now, the EJAB project is obsolete for more than a year so i'm closing this ticket. Let's follow up on https://github.com/processone/ejabberd/pull/32

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development