Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: ejabberd 13.12
    • Fix Version/s: ejabberd 14.07
    • Labels:
      None
    • Environment:
      Ubuntu 12.04.3 - Erlang 16B03 - 64bit

      Description

      It seems that PEP doesn't work any more with 13.12. I tried Gajim and Psi-Plus, the iq messages look like this:

      <iq type="set" id="ab84a">
      <pubsub xmlns="http://jabber.org/protocol/pubsub">
      <publish node="http://jabber.org/protocol/mood">
      <item id="current">
      <mood xmlns="http://jabber.org/protocol/mood">
      <tired/>
      </mood>
      </item>
      </publish>
      </pubsub>
      </iq>

      <iq from="matthias@sucksass.de" type="result" to="matthias@sucksass.de/Hamburg" id="ab84a">
      <pubsub xmlns="http://jabber.org/protocol/pubsub">
      <publish node="http://jabber.org/protocol/mood">
      <item id="current"/>
      </publish>
      </pubsub>
      </iq>

      But there's no message stanza, wether to myself nor to other contacts in my roster.

      The relevant part from the config:

      mod_pubsub:
      access_createnode: pubsub_createnode
      ignore_pep_from_offline: false
      last_item_cache: true
      plugins:

      • "flat"
      • "hometree"
      • "pep"

      ...

      mod_caps: {}

      As far as I understand the manual that should be sufficient for PEP.

        Activity

        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        indeed, default pep config comes with deliver_payloads=true, so you should not receive such stanza. i'll investigate this for the next release.

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - indeed, default pep config comes with deliver_payloads=true, so you should not receive such stanza. i'll investigate this for the next release.
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        fixed in 5871792

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - fixed in 5871792
        Hide
        sezuan Matthias Rieber added a comment - - edited

        Seems to be fixed with 23fdf0e889b89abe020d7d920d844717cda99ca4 but it's broken again, according to git bisect:

        bad: [7d594086c3601c3281473b4ca54714b714027019] Add initial XEP-0198 support (EJAB-532)

        master and tag-14.05 don't work, too.

        Removing the XEP-0198 merge fixes it:
        git revert -m 1 47f627e6058dd903836be193b92ddeb68ed5d742

        Show
        sezuan Matthias Rieber added a comment - - edited Seems to be fixed with 23fdf0e889b89abe020d7d920d844717cda99ca4 but it's broken again, according to git bisect: bad: [7d594086c3601c3281473b4ca54714b714027019] Add initial XEP-0198 support ( EJAB-532 ) master and tag-14.05 don't work, too. Removing the XEP-0198 merge fixes it: git revert -m 1 47f627e6058dd903836be193b92ddeb68ed5d742
        Hide
        holger Holger Weiß added a comment -

        Seems to be fixed with 23fdf0e889b89abe020d7d920d844717cda99ca4

        Is that a typo? That's the current master commit.

        Show
        holger Holger Weiß added a comment - Seems to be fixed with 23fdf0e889b89abe020d7d920d844717cda99ca4 Is that a typo? That's the current master commit.
        Hide
        holger Holger Weiß added a comment -

        I can reproduce it now, I'm sorry about that. I'll look into it.

        Show
        holger Holger Weiß added a comment - I can reproduce it now, I'm sorry about that. I'll look into it.
        Hide
        holger Holger Weiß added a comment -

        https://github.com/processone/ejabberd/pull/212 should fix this, as well as other issues. Sorry again

        Show
        holger Holger Weiß added a comment - https://github.com/processone/ejabberd/pull/212 should fix this, as well as other issues. Sorry again
        Hide
        sezuan Matthias Rieber added a comment -

        The fix works.

        Show
        sezuan Matthias Rieber added a comment - The fix works.
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        fix merged

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - fix merged

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development