Details

    • Type: Bug
    • Status: Closed
    • Priority: Low
    • Resolution: Done
    • Affects Version/s: ejabberd 14.05
    • Fix Version/s: ejabberd 14.07
    • Component/s: None
    • Labels:
      None

      Description

      The release version string that's reported e.g. by mod_version is set by some Git magic at the top of the configure.ac file. Right now it's set to 13.12.something. The magic is executed by autoconf, so I guess it would be good if the release building process would include running ./autogen.sh (from within the Git repository) after tagging the new release.

      see https://github.com/processone/ejabberd/issues/214
      to be fixed for 14.07

        Activity

        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        this empty version string can be avoided this way

        AC_INIT(ejabberd, m4_esyscmd([echo `git describe --tags 2>/dev/null || echo master` | sed 's/-g.*//' | tr -d '\012']), [ejabberd@process-one.net], [ejabberd])
        

        this way, if no git version available, version is set to "master" or whatever…

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - this empty version string can be avoided this way AC_INIT(ejabberd, m4_esyscmd([echo `git describe --tags 2>/dev/ null || echo master` | sed 's/-g.* //' | tr -d '\012']), [ejabberd@process-one.net], [ejabberd]) this way, if no git version available, version is set to "master" or whatever…
        Hide
        holger Holger Weiß added a comment - - edited

        Yup.

        (But don't you want to keep the -g.* part of the git describe output? I thought this is what using git describe as opposed e.g. to my suggestion is all about ...)

        Show
        holger Holger Weiß added a comment - - edited Yup. (But don't you want to keep the -g.* part of the git describe output? I thought this is what using git describe as opposed e.g. to my suggestion is all about ...)
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        yes, this was just a proposal.
        i'm not sure keeping -g with git hash is worth anyway
        14.05-97-gaba7150 vs 14.05-97

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - yes, this was just a proposal. i'm not sure keeping -g with git hash is worth anyway 14.05-97-gaba7150 vs 14.05-97
        Hide
        holger Holger Weiß added a comment -

        Ah sorry, I forgot the -97 part, so please just ignore me

        Show
        holger Holger Weiß added a comment - Ah sorry, I forgot the -97 part, so please just ignore me
        Hide
        cromain@process-one.net Christophe Romain (Inactive) added a comment -

        configure.ac script improved to give git version
        if outside git repository, it sets version to 'community'
        our delivery now adds a configure generated at release time, with correct version string included in official source tarball.

        Show
        cromain@process-one.net Christophe Romain (Inactive) added a comment - configure.ac script improved to give git version if outside git repository, it sets version to 'community' our delivery now adds a configure generated at release time, with correct version string included in official source tarball.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development