Details

      Description

      mod_proxy65 send an invalid SOCKS5 reply, which causes file transfers to fail (for example in Pidgin).

      The comment in mod_proxy65_lib.erl says that Psi can't handle correct replies, but then Psi is the place to fix it.
      ejabberd should be standard compliant.

        Activity

        Hide
        sniperbeamer Felix Geyer added a comment -

        Patch to fix this bug.

        Show
        sniperbeamer Felix Geyer added a comment - Patch to fix this bug.
        Hide
        mremond@process-one.net Mickaël Rémond added a comment -

        Thank you !


        Mickaël Rémond
        http://www.process-one.net/

        Show
        mremond@process-one.net Mickaël Rémond added a comment - Thank you ! – Mickaël Rémond http://www.process-one.net/
        Hide
        sniperbeamer Felix Geyer added a comment -

        Is this patch going to be included in the next bugfix release of ejabberd?

        Show
        sniperbeamer Felix Geyer added a comment - Is this patch going to be included in the next bugfix release of ejabberd?
        Hide
        badlop Badlop added a comment -

        Some more information: that code was committed almost two years ago (28 October 2006):
        https://forge.process-one.net/changelog/ejabberd?cs=666

        Maybe at that time Psi was the only or one of the few implementations of SOCKS5. I tried looking at Psi's bugtracker and SVN log, but I couldn't find any worth mention to such a bug, or any bug report.

        So either:
        A) The bug is already fixed in Psi, but I couldn't get any proof
        B) The bug is still there in Psi. In that case, it would be good to report it to them, and mention it in the ejabberd Release Notes.

        In any case, ejabberd should be standard compliant. If that patch works correctly, it should be included in the incoming ejabberd 2.0.2.

        Show
        badlop Badlop added a comment - Some more information: that code was committed almost two years ago (28 October 2006): https://forge.process-one.net/changelog/ejabberd?cs=666 Maybe at that time Psi was the only or one of the few implementations of SOCKS5. I tried looking at Psi's bugtracker and SVN log, but I couldn't find any worth mention to such a bug, or any bug report. So either: A) The bug is already fixed in Psi, but I couldn't get any proof B) The bug is still there in Psi. In that case, it would be good to report it to them, and mention it in the ejabberd Release Notes. In any case, ejabberd should be standard compliant. If that patch works correctly, it should be included in the incoming ejabberd 2.0.2.
        Hide
        mremond@process-one.net Mickaël Rémond added a comment -

        I am currently testing it.
        More feedback soon.


        Mickaël Remond

        Show
        mremond@process-one.net Mickaël Rémond added a comment - I am currently testing it. More feedback soon. – Mickaël Remond
        Hide
        badlop Badlop added a comment -

        The versions of Psi that are non-compliant and require the wrong mod_proxy65 response are Psi < 0.10

        The latest stable release of Psi is 0.11, so it isn't problematic for updated Psi users if ejabberd is XEP-compliant.

        Show
        badlop Badlop added a comment - The versions of Psi that are non-compliant and require the wrong mod_proxy65 response are Psi < 0.10 The latest stable release of Psi is 0.11, so it isn't problematic for updated Psi users if ejabberd is XEP-compliant.
        Hide
        badlop Badlop added a comment -

        The patch provided by Felix Geyer is applied to ejabberd trunk and 2.0.x branch in SVN r1488.

        Show
        badlop Badlop added a comment - The patch provided by Felix Geyer is applied to ejabberd trunk and 2.0.x branch in SVN r1488.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development