Uploaded image for project: 'ejabberd development'
  1. ejabberd development
  2. EJAB-876

Add subscription option support for collection nodes

    Details

      Description

      This patch requires EJAB-845 and EJAB-815, integrating them by allowing subscription depth and type to be set via subscription options.

        Issue Links

          Activity

          Hide
          bjc Brian Cully added a comment -

          Add subscription option and depth support for collection nodes.

          API:

          • Add get_parent_nodes/2 and get_parent_nodes_tree/2 to
            gen_pubsub_nodetree behavior. These functions act like their
            subnodes counterparts, except get_parent_nodes_tree, which also
            includes the depth of the node from the root of the selection. It
            might be a good idea for get_subnodes_tree/2 to do the same thing,
            but isn't required.
          • node plugin's get_node_subscriptions takes a list of nodes, not a
            single one now. This is to better split the concerns of nodetrees
            and nodes. It's still not perfect, as the case of a nodetree which
            has nodes of different types isn't handled.

          BUG FIXES:

          • Catch errors when trying to delete nodes which don't exist.
          Show
          bjc Brian Cully added a comment - Add subscription option and depth support for collection nodes. API: Add get_parent_nodes/2 and get_parent_nodes_tree/2 to gen_pubsub_nodetree behavior. These functions act like their subnodes counterparts, except get_parent_nodes_tree, which also includes the depth of the node from the root of the selection. It might be a good idea for get_subnodes_tree/2 to do the same thing, but isn't required. node plugin's get_node_subscriptions takes a list of nodes, not a single one now. This is to better split the concerns of nodetrees and nodes. It's still not perfect, as the case of a nodetree which has nodes of different types isn't handled. BUG FIXES: Catch errors when trying to delete nodes which don't exist.
          Hide
          bjc Brian Cully added a comment -

          EJAB-815 now contains this feature.

          Show
          bjc Brian Cully added a comment - EJAB-815 now contains this feature.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development